silverstripe / silverstripe-admin

Silverstripe Admin Component
BSD 3-Clause "New" or "Revised" License
25 stars 91 forks source link

Default browser image icon with title = "Image not found" #1709

Open sabina-talipova opened 3 months ago

sabina-talipova commented 3 months ago

Description

ENV: SC PHP8.3 Chrome Installer

I see default browser image icon with title = "Image not found" if I insert image in WYSIWYG editor and image is not published.

Screenshot_2024-03-13_at_10 33 43_AM (1)

Steps to reproduce issue

GuySartorelli commented 3 months ago

What steps did you take to get into this condition? I assume you unpublished the image after publishing the page?

Have you checked this behaviour locally in 5.1 to be sure it's a regression with Silverstripe CMS?

sabina-talipova commented 3 months ago

What steps did you take to get into this condition?

I follow scenarios that we have in Cucumber Studio.

I assume you unpublished the image after publishing the page?

It is one of the step. Please, see this instruction (https://studio.cucumber.io/projects/301855/test-plan/folders/2145967/scenarios/7080337).

Have you checked this behaviour locally in 5.1 to be sure it's a regression with Silverstripe CMS?

I'll check, but I think it exists in CMS 5.1 as well, we just ignored it as an issue when did last regression tests. It's not a regression issue. I think main question is it expected behaviour, that we show browser image icon like a message "here should be image, but something went wrong" or we should avoid any missing content.

GuySartorelli commented 3 months ago

Yeah definitely something we need to decide how to handle - my main point is if it's not a regression we can handle it after 5.2.0, whereas if it's a regression we probably need to prioritise it sooner.

maxime-rainville commented 3 months ago

I couldn't replicate this locally. Do we still have this issue in the sandbox?

sabina-talipova commented 3 months ago

I tested on 5.2 and 5.1 in my local. Issue exists.

Screenshot 2024-03-19 at 8 26 59 AM

I've updated the description with steps how to reproduce issue.