silverstripe / silverstripe-admin

Silverstripe Admin Component
BSD 3-Clause "New" or "Revised" License
25 stars 91 forks source link

FIX Correctly validate emails in WYSIWYG links #1710

Closed GuySartorelli closed 3 months ago

GuySartorelli commented 3 months ago

Description

Ensure the correct EmailField form field is used for entering email addresses in WYSIWYG links. This provides appropriate validation errors when incorrect values are entered.

Note I haven't added behat for this because shockingly there is no behat at all in this module for WYSIWYG links - so adding them in this PR for this fix is a bit overkill.

Manual testing steps

In any WYSIWYG field, try to add an email address link with an invalid email address. You should be given an appropriate validation error within the modal form.

Issues

Pull request checklist

GuySartorelli commented 3 months ago

JS CI failure is unrelated to the changes in this PR.