silverstripe / silverstripe-admin

Silverstripe Admin Component
BSD 3-Clause "New" or "Revised" License
25 stars 92 forks source link

fast click on gridfield trigger js error #626

Open lekoala opened 6 years ago

lekoala commented 6 years ago

Navigate to a ModelAdmin section and quickly click on a row. If you click too fast, the url parameter is not set yet and result in a js error. It's probably even worse on a slow browser.

Tested with 4.2

I only get the error on my website, not a fresh install. With a fresh install, no errors appear in the console (not sure why), but the click is ignored (probably for the same reason).

vendor.js?m=1532976963:1 Uncaught TypeError: Parameter 'url' must be a string, not undefined
    at o.parse (vendor.js?m=1532976963:1)
    at r (vendor.js?m=1532976963:1)
    at Object.i [as resolve] (vendor.js?m=1532976963:1)
    at Function.o (bundle.js?m=1533045325:1)
    at Function.show (bundle.js?m=1533045325:1)
    at init.loadPanel (bundle.js?m=1533045325:1)
    at s (vendor.js?m=1532976963:1)
    at init.loadPanel (vendor.js?m=1532976963:1)
    at init.showDetailView (bundle.js?m=1533045325:1)
    at s (vendor.js?m=1532976963:1)
maxime-rainville commented 5 years ago

I can confirm this. My favicon for some weird reason takes 5-6 seconds to load, which seems to prevent some JS event from getting wired. If I clicked on a ModelAdmin row I get this error.

lekoala commented 3 years ago

This is still happening on 4.7 (got the issue recently)

lekoala commented 3 years ago

:-) still happening on 4.8. I have no idea what is setting the url, but clearly it's not doing the job as fast as it should

NightJar commented 1 year ago

Have this issue in SiteConfig, many minutes after loading the page. I clicked "cms-content-header-info". Each subsequent click repeats the error. CMS 4.7

image