search

silverstripe / silverstripe-admin

Silverstripe Admin Component
BSD 3-Clause "New" or "Revised" License
25 stars 94 forks source link

Clean out ss-ui-button CSS class use #732

Open chillu opened 7 years ago

chillu commented 7 years ago

Overview

We've removed the reliance of buttons on jQuery UI (see https://github.com/silverstripe/silverstripe-framework/pull/6354 and follow up PRs). This also meant renaming button classes from .ss-ui-button to .btn. There's still 54 matches of the old .ss-ui-button classes around SCSS/JS/SS/PHP files in core though - we need to clean this out

Related

chillu commented 7 years ago

@wilr Given you kicked off the UI button refactor, would you be able to help out with this? :D

wilr commented 7 years ago

Sure :) 👍 I thought I had got all the ones out of framework and CMS but the original commits have been rebased so many times.

wilr commented 7 years ago

@chillu Let me know if any specific modules you want to me update as well for 4.0. Most of the modules didn't install on 4.0 (like userforms) so don't want to double up any upgrade work internally.

tractorcow commented 7 years ago

There's still one place where I haven't been able to remove these clases, which is in the legacy insert media dialog, which itself is a jquery-ui dialog. If we can remove this (and rely on the new asset-admin dialog) we can make this task a lot easier. I suggest to focus on removing UploadField in advance of expecting the end of ss-ui-button.

chillu commented 7 years ago

@wilr I guess upgrading modules with CMS customisations (new buttons) would be done as part of upgrading other aspects of the modules - IMHO it's more important to clean up core for now.