search

silverstripe / silverstripe-admin

Silverstripe Admin Component
BSD 3-Clause "New" or "Revised" License
25 stars 93 forks source link

Form should not have a border-bottom on the last child #752

Open robbieaverill opened 5 years ago

robbieaverill commented 5 years ago

Version: SS 4.3.0-rc1 (in CWP 2.2.0-rc1 context)

Whenever a form that doesn't have --no-dividers or an equivalent class to remove the dividers lines is used, we should exclude the last child from being given a bottom border. Example from asset-admin where there's only one field:

image

robbieaverill commented 5 years ago

I've made a PR to fix this particular form factory in place: https://github.com/silverstripe/silverstripe-asset-admin/pull/881

ScopeyNZ commented 5 years ago

Is there more form factories that just that one? That PR is now merged.

robbieaverill commented 5 years ago

Yeah probably, but I think this issue should be treated separately. If a form doesn't use the form--no-dividers class I think we should remove the last child's border