search

silverstripe / silverstripe-admin

Silverstripe Admin Component
BSD 3-Clause "New" or "Revised" License
25 stars 92 forks source link

Add new loading indicator to pattern library #797

Open newleeland opened 5 years ago

newleeland commented 5 years ago

Potential AC:

As SilverStripe we want to replace SilverStripe branded loading indicator with a more generic one as (basically we're sub consciously anchoring into users of the CMS, slow loading is because its SilverStripe).

Potential design:

https://projects.invisionapp.com/dsm/silver-stripe/silver-stripe/folder/components/5b9eeec5e2cb730017f84a1f

Animations should follow bootstrap spinner: https://getbootstrap.com/docs/4.2/components/spinners/.

maxime-rainville commented 5 years ago

<sarcarsm> What about a Wordpress/Drupal branded loading indicator instead? </sacarsm>

robbieaverill commented 5 years ago

For reference, Bootstrap 4.2 was released a month ago which has a bunch of spinner components: https://getbootstrap.com/docs/4.2/components/spinners/. It might make sense to make whichever design we choose to implement work as a variation or state of this component so it can use some of the OOB spinner component styles etc.

Matching Reactstrap update is version 7 which supports this component.

newleeland commented 5 years ago

For reference, Bootstrap 4.2 was released a month ago which has a bunch of spinner components: https://getbootstrap.com/docs/4.2/components/spinners/. It might make sense to make whichever design we choose to implement work as a variation or state of this component so it can use some of the OOB spinner component styles etc.

Yeah bootstrap 4 spinners is perfect. We could just change the colour to our colours. be good to not add too many custom styling from our end! @robbieaverill