robbieaverill
commented
5 years ago Bump the z-index for the login modal?
Open NightJar opened 5 years ago
robbieaverill
commented
5 years ago Bump the z-index for the login modal?
NightJar
commented
5 years ago In short, yes. In length: please be sure not to create a race to the sky :)
This is more than likely caused by placement of the respective stacking contexts, examining those and attempting to fix at the root is more reasonable than z-index: calc(9999999999999999+1);
I didn't look into this at all, simply bumping z-index probably won't work anyway (if it's a stacking context issue).
ScopeyNZ
commented
5 years ago The other option would be to ensure the loading container is never added after the login modal in the DOM - assuming they currently have default z-index. Would be a case of updating the code that inserts the loading container to look for the login modal container before deciding where to inject the new container.
NightJar
commented
5 years ago Yep, DOM ordering is what I meant by placement :)
Ideally the veil is part of the grid field/page component, but currently both of these things are rendered by entwine. In any case I'd expect the loading veil to be closer to the base of the 'main' part of LeftAndMain, rather than in the global root, where I expect the modal to live.
Reality could be completely different though.
I'm also slightly befuddled by the loading indicator - should it not also have a veil backdrop over the entire admin area? I'm not 100% on this, but if so... does the loading indicator veil on the page preclude a veil being added to the entire CMS for the modal? @clarkepaul
clarkepaul
commented
5 years ago @NightJar yep there is no reason why it doesn't fill the whole space. Those loading screens should either fill the given panel or the entire screen.
The below screenshot is taken from the
kitchen-sinktesting recipe (versions of all things shown below). I am attempting to test a feature refactor for the comments module (shifting the spam buttons into the "ActionMenu" pop-out menu), and have left it too long between tests. I am being prompted to log back in, however cannot access the input to put my password into as it is below the "loading" vignette for the page, which I've triggered by clicking aGridField_ActionMenuItem.I guess the short recreate steps would be: