silverstripe / silverstripe-admin

Silverstripe Admin Component
BSD 3-Clause "New" or "Revised" License
25 stars 95 forks source link

Add React based password field with strength indicator #885

Open robbieaverill opened 5 years ago

robbieaverill commented 5 years ago

High level ideas for a React based PasswordField component:

In scope:

Out of scope:

Resources:

Notes:

sachajudd commented 5 years ago

Last pass example:

image

robbieaverill commented 5 years ago

This is what we have at the moment:

image

See Member::getMemberPasswordField() which is used in Member::getCMSFields(). We can probably built a UI for this and not have breaking changes. See FormField::$schemaComponent to define the React component to use.

robbieaverill commented 5 years ago

cc @StephenMakrogianni, WIP branch https://github.com/robbieaverill/silverstripe-admin/commit/34fa74c8d580f1318c91479fe0eec61476f535e0

sachajudd commented 5 years ago

See Style guide for potential concepts. I think we go for the MVP concept first and look into how we can improve the other concept for the future. Note: Colours to be confirmed seeing as these are not consistent patterns currently in the CMS and we want to make sure they're accessible.

robbieaverill commented 5 years ago

Work in progress branches here:

I've got most of a storybook component working. It needs to be hooked into SilverStripe, unit tested, UI tweaked (we're using temporary font icons and colours are probably not accessible), have the zxcvbn bundle pulled out into its own file.