search

silverstripe / silverstripe-akismet

Akismet module for Silverstripe
Other
2 stars 6 forks source link

Check and update for SS4 compatability #23

Closed raissanorth closed 6 years ago

raissanorth commented 6 years ago

In progress.

robbieaverill commented 6 years ago

Ok so we've replaced the public static methods with an injectable service for AkismetSpamProtector, and defined the order of priority for API key definition as:

  1. Set to singleton via public API
  2. Config API
  3. Environment

There's still the issue of the form validation message not showing up during the functional test, which we've marked as incomplete for now.

The intention is to test this module when we check the spam protector module shortly (https://github.com/silverstripe/silverstripe-spamprotection/issues/62).

@tractorcow would you mind having a review of this pull request and see what you think?