search

silverstripe / silverstripe-asset-admin

Silverstripe assets gallery for asset management
BSD 3-Clause "New" or "Revised" License
20 stars 79 forks source link

Image with caption should use <figure> and <figcaption> #1318

Open kinglozzer opened 1 year ago

kinglozzer commented 1 year ago

Currently the markup is roughly:

<div class="captionImage leftAlone">
    <img src="people.jpg" width="123" height="456" alt="Team photo" />
    <p class="caption leftAlone">From left to right: John, Karen, Richard</p>
</div>

This should be represented by <figure> and <figcaption> elements:

<figure class="captionImage leftAlone">
    <img src="people.jpg" width="123" height="456" alt="Team photo" />
    <figcaption class="caption leftAlone">From left to right: John, Karen, Richard</figcaption>
</figure>

The same applies to captions added to embedded videos.

PRs

kinglozzer commented 1 year ago

Initial PR: https://github.com/silverstripe/silverstripe-asset-admin/pull/1321. I need to rebase it and do a matching PR for framework

GuySartorelli commented 1 year ago

Are you still interested in this @kinglozzer?