search

silverstripe / silverstripe-asset-admin

Silverstripe assets gallery for asset management
BSD 3-Clause "New" or "Revised" License
19 stars 78 forks source link

ENH Add delete buttons for images/embeds in wysiwyg #1331

Closed GuySartorelli closed 1 year ago

GuySartorelli commented 1 year ago

The stretch goals are shockingly non-trivial, so I'm not touching those. This PR just adds nice delete buttons when you select an image or embed (and behat tests for the selection context toolbars).

I've added the delete button to embeds and images, to keep things consistent.

Parent issue

GuySartorelli commented 1 year ago

js test failure is expected until https://github.com/silverstripe/silverstripe-asset-admin/pull/1330 is merged in

GuySartorelli commented 1 year ago

Rebased so js tests can pass, and resolved feedback.