search

silverstripe / silverstripe-asset-admin

Silverstripe assets gallery for asset management
BSD 3-Clause "New" or "Revised" License
20 stars 79 forks source link

FIX Ensure fresh options are passed to dropzone #1353

Closed emteknetnz closed 1 year ago

emteknetnz commented 1 year ago

Issue https://github.com/silverstripe/silverstripe-asset-admin/issues/1352

Reverts part of this commit - https://github.com/silverstripe/silverstripe-asset-admin/commit/45e7461a549ae858999eacd8d11eaeb4bbe13515#

emteknetnz commented 1 year ago

I don't think this is possible unfortunately.

This regression only happens when you click "Upload new" rather that "Choose existing', and you select a file from the (native) file selector dialog.

Unfortunately there isn't a way to get behat to "select a file from the file selector" - when you get behat to click "Upload new", there is no file selector, though the link "Upload new" is underlined.

There are no existing tests where "Upload new is clicked", in fact all the "upload" tests will "Choose existing" i.e. pre-uploaded files - so I'm not the first person to run into this issue.

I think we'll just have to make do with the behat test as it is.

GuySartorelli commented 1 year ago

Bugger. Well, we can't win em all 😅