search

silverstripe / silverstripe-asset-admin

Silverstripe assets gallery for asset management
BSD 3-Clause "New" or "Revised" License
19 stars 78 forks source link

Adds Folder ID for TinyMCE_sslink-file to allow us to target a specif… #1359

Closed gazzayeatman closed 1 year ago

gazzayeatman commented 1 year ago

Targeting 1.11 as thats the version we're using in this case.

Copied the code from TinyMCE_ssmedia to allow us to send a folderID to TinyMCE_sslink-file.

Tested locally for our specific use case and it appears to work.

The problem we are trying to solve. Our client has a website hosts pages for specific centres across Australia. They have a folder structure where each centre has a directory to upload files to. They also have set up a permissions model to only allow a specific centre to view their own directory and no others.

Previously when they were trying to link a file they would be met with an exception because they were defaulted to the root assets directory which they did not have access to. We would like to be able to point them to their centre's directory by default so they don't get met with this exception and improve the UX. I hope that helps.

michalkleiner commented 1 year ago

@GuySartorelli I think the change is about being able to provide a default folder for file upload fields so that the user don't need to always select it, not about allowing linking to a folder instead of a file. Correct me if I'm wrong @gazzayeatman. With that, I wouldn't expect this needing specific UX review. Perhaps some UI test, but also not critical from my perspective.

GuySartorelli commented 1 year ago

Ahh okay - in that case @gazzayeatman can you please write a clear description of what problem this is solving in the pr description? Just to clear up exactly what this is intended to do.

gazzayeatman commented 1 year ago

@GuySartorelli Sorry for the delay. I've updated the description

GuySartorelli commented 1 year ago

It could be argued that this is a new feature, but honestly it seems broken to me that the media plugin would respect the folder for the wysiwyg config but the link to file plugin didn't - so I'm considering this a bug fix which allows us to release it as a patch for CMS 4.

Released as 1.13.2. It'll also get a patch release against the 2.0 minor at some stage after merge-ups are done.

emteknetnz commented 1 year ago

This has been released in 2.0.1