search

silverstripe / silverstripe-asset-admin

Silverstripe assets gallery for asset management
BSD 3-Clause "New" or "Revised" License
19 stars 78 forks source link

MNT Fix js lint errors #1388

Closed emteknetnz closed 10 months ago

emteknetnz commented 10 months ago

Issue https://github.com/silverstripe/.github/issues/99

I did a merge-up from 2.0 => 2 though there were some yarn lint failures which I choose to ignore for the sake of completing the merge-up without having to commit changes without a PR. I've fixed the yarn lint errors in this PR

The yarn lint errors were

vendor/silverstripe/asset-admin/client/src/containers/AssetAdmin/AssetAdmin.js
  686:13  error  'archiveFiles' is assigned a value but never used  no-unused-vars

vendor/silverstripe/asset-admin/client/src/containers/BulkDeleteConfirmation/BulkDeleteMessage.js
  78:5  error  Prefer fragment shorthand over React.Fragment  react/jsx-fragments

vendor/silverstripe/asset-admin/client/src/containers/BulkDeleteConfirmation/DeletionModal.js
  22:1  error  Expected indentation of 8 spaces but found 10  indent

Note this PR is only fixing lint issues, there is a broken behat test on this which will be an existing failure

GuySartorelli commented 10 months ago

there is a broken behat test on this which will be an existing failure

Is there a PR to fix that?