TODO: Refactor "queued files" into separate visual area and remove coupling here

silverstripe / silverstripe-asset-admin

Silverstripe assets gallery for asset management

BSD 3-Clause "New" or "Revised" License

19 stars 78 forks source link

TODO: Refactor "queued files" into separate visual area and remove coupling here #1407

Closed sabina-talipova closed 8 months ago

sabina-talipova commented 8 months ago

Description

We should refactor "queued files" into separate visual area and remove coupling in some functions in asset admit.

handleMoveFilesSuccess. See
mapStateToProps. See
mapDispatchToProps. See

GuySartorelli commented 8 months ago

@sabina-talipova What are "queued files" and what would a separate visual area be like? I think this is one of those issues where we don't have enough context and should probably close it.

sabina-talipova commented 8 months ago

I left this TODO comment, because I think that the main idea here was to extract queuedFiles and all related logic into additional Component. But if you think that we are not going to spend time on this enhancement we can close this ticket.

GuySartorelli commented 8 months ago

I think the status quo is probably okay for now - we're not likely to spend time on this in the foreseeable future.