silverstripe / silverstripe-asset-admin

Silverstripe assets gallery for asset management
BSD 3-Clause "New" or "Revised" License
19 stars 78 forks source link

ENH Improve quality of thumbnails in assetadmin and uploadfield #1447

Closed GuySartorelli closed 3 months ago

GuySartorelli commented 3 months ago

Description

See https://github.com/silverstripe/silverstripe-asset-admin/pull/1224 for more details - there was a lot of discussion in there.

Manual testing steps

Before pulling this PR, add a bunch of different images to asset admin, and into upload fields. Then pull this PR. Check asset admin (both tile and gallery view) - you should see the new thumbnails. Check uploadfield - you should see the new thumbnails there too.

If the thumbnails were blurry before the PR, you should notice a stark improvement after pulling the PR.

Issues

Pull request checklist

GuySartorelli commented 3 months ago

Closing - we can reuse this code when we're ready to pull this through for CMS 6. We'll need to provide a clear way (e.g. a BuildTask) for projects upgrading to generate their new thumbnails in a way that doesn't require sitting and waiting for them to regenerate for each page of images you visit in the asset admin.