silverstripe / silverstripe-asset-admin

Silverstripe assets gallery for asset management
BSD 3-Clause "New" or "Revised" License
20 stars 79 forks source link

Mandatory metadata on file upload #713

Closed chillu closed 5 years ago

chillu commented 6 years ago

Overview

Organisations have different metadata requirements for asset management that should be consistently enforced at upload time. After upload, a file can be used both programmatically and through the CMS UI, and the system might not get a chance to ask for this metadata.

These capabilities would get us a lot closer to functioning as a Digital Asset Management (DAM) system.

Acceptance Criteria

Sample Uses

Notes

Related

/cc @frankmullenger @clarkepaul

chillu commented 6 years ago

@clarkepaul Frank and his team might need this early next year, do you want to get this on your design backlog to sketch out?

clarkepaul commented 6 years ago

Added to backlog cheers.

frankmullenger commented 6 years ago

Preventing upload of an asset before validation of File object isn't a hard requirement for us. However, we would somehow want to either control if the File can be used anywhere by content authors if it doesn't have the necessary metadata or report to content authors where they are using invalid Files.

Might be worth considering that some metadata might be retrieved via Oembed from a third party in some cases as well. This is mostly for videos that are hosted on youtube etc. but we are likely using a subclass of File for those for various reasons.

chillu commented 6 years ago

Yeah I'm not sold on preventing upload either, it might complicate the implementation. A report on invalid files might fulfil the same purpose.

clarkepaul commented 6 years ago

Had a quick chat to @frankmullenger and seems they went with a lighter approach where they just notify users as a warning that some fields are missing potentially important information, rather than a forced requirement.

I don't think all those sample fields should be set as "required" fields globally as some files wouldn't have a license, content review period, or crop variation.

@ingo is it possible to show notifications based on the placement a file is intended to be used, like on the uploadfield itself ( eg. "this file is missing details XYZ to be used for this placement")?

chillu commented 6 years ago

Hmm, context specific validation seems like it would frustrate authors quickly. We do have some of that in "insert image" into rich text areas, where you're force to set an alt text for an image in CWP environments. We want to keep the UIs as consistent as possible across their implementations though, so these special cases make our mainentenance harder

clarkepaul commented 6 years ago

context specific validation seems like it would frustrate authors quickly

Likewise having a required license field for every file when it only needed in a few instances would be annoying. Agree that there needs to be the flexibility to have additional fields but I'm just trying to get my head around whether having an additional dialog interface is any better than just adding additional fields/tabs to edit panel of the file and running validation on those fields, and showing alerts if not satisfactory? I think a chat might clear things up a bit, keen to have a chat @chillu

clarkepaul commented 6 years ago

@frankmullenger is this still something which is on the cards or have you taken any steps to provide this functionality?

frankmullenger commented 6 years ago

@clarkepaul we have provided some functionality that meets requirements for the project, so we are not relying on this piece of work at all thanks.

clarkepaul commented 6 years ago

@frankmullenger cheers, I'm removing this from the UX priority list for now. It'll still remain in the backlog though as it will probably surface again in some form. Leave it up to @chillu whether we keep it.

chillu commented 6 years ago

Moving this back to Icebox, not a priority right now

chillu commented 5 years ago

I'm closing this, the key project has solved this differently, and I don't see us doing this anytime soon.