search

silverstripe / silverstripe-assets

Silverstripe Assets component
BSD 3-Clause "New" or "Revised" License
9 stars 67 forks source link

Tag 1.3.4 / backport https://github.com/silverstripe/silverstripe-assets/pull/209 #229

Closed wilr closed 5 years ago

wilr commented 5 years ago

Just been bitten hard by https://github.com/silverstripe/silverstripe-assets/pull/209 which doesn't appear in any release yet (as recipe uses ^1.3). Been a couple of months since that patch so good to get an update into CWP releases to save the next developer.

ScopeyNZ commented 5 years ago

I can't see why that PR targeted 1. It's even marked as a patch. Makes sense to backport it imo.

robbieaverill commented 5 years ago

Yeah, feel free to backport by hand if you want to @wilr

chillu commented 5 years ago

Patch level fixes should be applied to release lines in active development or full support, which is 4.2 and newer as of 1st of April (https://www.silverstripe.org/blog/update-on-silverstripe-5-x/). I've reminded the team about this process :)

@wilr Would you be able to send a backport PR to 1.2, and check that it fixes your issue there?

robbieaverill commented 5 years ago

This is tagged now