silverstripe / silverstripe-assets

Silverstripe Assets component
BSD 3-Clause "New" or "Revised" License
9 stars 65 forks source link

Change in file hash results in duplicated images #519

Open emteknetnz opened 1 year ago

emteknetnz commented 1 year ago

This PR https://github.com/silverstripe/silverstripe-assets/pull/518 highlighted a change where manipulated image hashes can be different because of https://github.com/silverstripe/silverstripe-framework/pull/10497

This will result in duplicate images with different files names which is a waste of server storage space

This will affect images directly added to template files with image manipulations performed on them. Off the top of my head I'm not sure if this also affects WYSIWYG inserted images, which presumably would be a larger issue (need to confirm when fixing this work)

A couple of options: