Deprecate a bunch of legacy file method and tasks

maxime-rainville commented 1 year ago

Around CMS4.4 we/I did a big refactor of the assets system. We have a bunch deah weight code that needs to be removed.

This PR make sure everything throws deprecation warnings.

I've also removed a bunch of @internal statement. This is mostly because:

the replacement method for some of the deprecated method was not officially supported or
can deprecate a method that is not officially supported.

In the case of the file resolution logic, we didn't want to support it because we wanted the flexibility to change it if it turn out to be have some problem. We haven't had to change anything to it, so it's probably safe to assume to support it at this stage.

Parent issue

https://github.com/silverstripe/silverstripe-assets/issues/521

GuySartorelli commented 1 year ago

Broken builds are because the way deprecation notice works is borked. Rerun CI after https://github.com/silverstripe/silverstripe-framework/issues/10550 is complete.

GuySartorelli commented 1 year ago

CI is still failing

emteknetnz commented 1 year ago

@GuySartorelli @maxime-rainville failing builds should get resolved by merging this first and re-running https://github.com/silverstripe/silverstripe-framework/pull/10556

silverstripe / silverstripe-assets

Deprecate a bunch of legacy file method and tasks #525

Parent issue