ENH tidy up InterventionBackend::getImageResource()

silverstripe / silverstripe-assets

Silverstripe Assets component

BSD 3-Clause "New" or "Revised" License

9 stars 66 forks source link

ENH tidy up InterventionBackend::getImageResource() #527

Closed christopherdarling closed 9 months ago

christopherdarling commented 1 year ago

Now that our minimum PHP version is >7.2 PHP supports stream based exif data. Since intervention/image 2.6 https://github.com/Intervention/image/commit/3ab514c80461929e9f7010f1dfbf69287beb6fc8 exif data can be extracted from streams so this logic appears no longer required

Link to previous PR for context https://github.com/silverstripe/silverstripe-assets/pull/409

michalkleiner commented 1 year ago

@christopherdarling the failing tests seem directly related to this, can you please have a look?

kinglozzer commented 1 year ago

Looks like this is blocked by https://github.com/Intervention/image/pull/1192

GuySartorelli commented 9 months ago

It seems like there's going to be no further activity on this pull request, so we’ve closed it for now. Please open a new pull-request if you want to re-approach this work, or for anything else you think could be fixed or improved.