search

silverstripe / silverstripe-assets

Silverstripe Assets component
BSD 3-Clause "New" or "Revised" License
9 stars 65 forks source link

FileIDHelperResolutionStrategy::findVariants() ordering issue #534

Open emteknetnz opened 1 year ago

emteknetnz commented 1 year ago

findVariants() seems to be having some issue with the order of results returned

This was first noticed in https://github.com/silverstripe/silverstripe-assets/commit/349508447b66591671b8930a25cd3fc1f78fb97e#diff-0668b7adbf9e875b66c47d35627b4ed054921175c1c8583e407607e4c4629353R526 where the order was changed

I experienced it again locally, and fixed this unit test to be order agnostic https://github.com/silverstripe/silverstripe-assets/pull/535

Investigate to see if this is something that we should even be worried about, and if there's a fix