silverstripe / silverstripe-assets

Silverstripe Assets component
BSD 3-Clause "New" or "Revised" License
9 stars 66 forks source link

API Explicitly deprecate legacy file resolution #543

Closed GuySartorelli closed 1 year ago

GuySartorelli commented 1 year ago

Can't be done the same way as other deprecation behaviours because of the problem mentioned in https://github.com/silverstripe/silverstripe-framework/pull/10702#discussion_r1116403808 So instead of interrogating the configuration, we're only emitting this deprecation warning if we actually find files which are in a legacy file structure.

This does mean the deprecation warning will be somewhat intermittent (only the oldest files in a project are likely to trip this, so it relies on developers happening to hit endpoints that call for those files) I think this is the best we can do.

Parent issue