search

silverstripe / silverstripe-assets

Silverstripe Assets component
BSD 3-Clause "New" or "Revised" License
9 stars 65 forks source link

Add support for braille format files #574

Closed edwilde closed 8 months ago

edwilde commented 8 months ago

This adds support for the Braille ASCII file format.

Issue

GuySartorelli commented 8 months ago

Please target this to the 2 branch - we aren't releasing any new minor releases for the 1.x release line. You may need to reset your commits after retargetting it.

GuySartorelli commented 8 months ago

Please also add this to an appropriate category (I presume "document") in the app_categories array in the File class.

If the intention is to not need any additional configuration in order to be able to upload these files, please also add it to the allowed_extensions array in the File class.

GuySartorelli commented 8 months ago

@edwilde Have you had a chance to look at this? The other PRs are looking good, so once these changes are made I'll do a last quick check and most likely merge.

edwilde commented 8 months ago

Thanks @GuySartorelli, unfortunately your earlier comments got lost in the malaise of github notifications 🤠

GuySartorelli commented 8 months ago

Rebased and force pushed so we get an accurate CI run