Shortcode are not being cached

maxime-rainville commented 2 months ago

Module version(s) affected

2.2.0, but probably all version of 2

Description

The method that's meant to check the cache for FileShortcodeProvider and ImageShortcodeProvider will always return an empty string unless you allow session grant.

In CMS4, I think session grant was enabled by default so this wasn't a problem.

https://github.com/silverstripe/silverstripe-assets/blob/ff5e8a743eea9cdddb900579a6e8c3d77a48e8ba/src/Shortcodes/FileShortcodeProvider.php#L137-L150

How to reproduce

Add a die('cache hit'); statement in this if clause https://github.com/silverstripe/silverstripe-assets/blob/ff5e8a743eea9cdddb900579a6e8c3d77a48e8ba/src/Shortcodes/ImageShortcodeProvider.php#L59-L64.
Add an Image to a WYSIWYG and publish the page.
Access the page twice.

Expected results: I hit the die statement. Actual: My cache check always returns a blank string and I regenerate the short code each time.

Possible Solution

No response

Additional Context

No response

Validations

[X] Check that there isn't already an issue that reports the same bug
[X] Double check that your reproduction steps work in a fresh installation of silverstripe/installer (with any code examples you've provided)