silverstripe / silverstripe-blog

Blog module for Silverstripe CMS
http://silverstripe.org/blog-module
BSD 2-Clause "Simplified" License
103 stars 169 forks source link

Can't edit posts in SS4 #493

Closed asecondwill closed 6 years ago

asecondwill commented 6 years ago

The cursor changes on hover, but clicking doesn't open the post edit screen

my modules are:

        "silverstripe/recipe-plugin": "^1",
        "silverstripe/recipe-cms": "1.0.0@stable",
        "dnadesign/silverstripe-elemental": "2.x-dev",
        "silverstripe/elemental-blocks": "1.0.x-dev",
        "dnadesign/silverstripe-elemental-userforms": "1.x-dev",
        "dnadesign/silverstripe-elemental-list": "^1.0@dev",
        "heyday/silverstripe-menumanager": "~3.0.0",
        "silverstripe/blog": "3.0.0-alpha1"
robbieaverill commented 6 years ago

Thanks for reporting. We'll be looking at getting the blog module to beta soon.

asecondwill commented 6 years ago

Do you know when this might happen?

robbieaverill commented 6 years ago

Probably in the few weeks after the holiday break, unless someone in the community wants to look and it and make a pull request before we get to it ;)

asecondwill commented 6 years ago

ok, cool. thanks. i'd love to, but probably beyond my skills, plus , tis the season for stupid deadlines

: )

asecondwill commented 6 years ago

in case anybody else finds this an issue in the meantime, I'm working around it using -

https://github.com/jonom/silverstripe-betternavigator/tree/4.0.0

which allows nav to post in front end, then click edit

asecondwill commented 6 years ago

Looks like its a css thing. edit button is there, just invisible.

download

raissanorth commented 6 years ago

I am using 3.0.x-dev and can't reproduce the error. The edit button appears fine:

image.png

Can you please confirm @asecondwill that this is still an issue for you? Thanks.

robbieaverill commented 6 years ago

Thanks for trying to reproduce this @raissanorth! I'll close this for now. @asecondwill feel free to reopen the issue if you're still having problems with it (ensure you update your dependencies!)

asecondwill commented 6 years ago

Hi, I updated my dependancies for blog

"silverstripe/blog": "3.*",

which installs 3.0.0

the problem persists. Ill try again next new project.

dhensby commented 6 years ago

@asecondwill can you try to provide us with some consistent steps to reproduce this, please?

asecondwill commented 6 years ago

I tried it today using a fresh install. Same issue. no edit button.

Steps

composer create-project silverstripe/installer . 4.1.0   
# run though visual installer.  login to admin
composer require silverstripe/blog
php vendor/silverstripe/framework/cli-script.php dev/build
# create new blog, create new blog post.  hover over it to get edit button.  see no edit button.

image

asecondwill commented 6 years ago

thats using firefox 58

asecondwill commented 6 years ago

composer.jsonfor details

{
    "name": "silverstripe/installer",
    "type": "silverstripe-recipe",
    "description": "The SilverStripe Framework Installer",
    "require": {
        "php": ">=5.6.0",
        "silverstripe/recipe-plugin": "^1",
        "silverstripe/recipe-cms": "1.1.0@stable",
        "silverstripe-themes/simple": "~3.2.0",
        "silverstripe/blog": "^3.1"
    },
    "require-dev": {
        "phpunit/phpunit": "^5.7"
    },
    "extra": {
        "branch-alias": {
            "4.x-dev": "4.2.x-dev",
            "dev-master": "5.x-dev"
        },
        "project-files-installed": [
            "mysite/.htaccess",
            "mysite/_config.php",
            "mysite/_config/mysite.yml",
            "mysite/code/Page.php",
            "mysite/code/PageController.php"
        ],
        "public-files-installed": [
            ".htaccess",
            "index.php",
            "install-frameworkmissing.html",
            "install.php",
            "web.config"
        ]
    },
    "config": {
        "process-timeout": 600
    },
    "prefer-stable": true,
    "minimum-stability": "dev"
}
asecondwill commented 6 years ago

I also tried this on 4.0.3 to see if it was todo with some issues I had with the new "public" folder in 4.1.0 but same issue.

NightJar commented 6 years ago

@asecondwill can you please use your browser's developer tools and inform us if you're seeing any 404 responses in the network tab? I too use Firefox and cannot replicate this issue.

I feel as if there's something not exposing as an asset at install time.

NightJar commented 6 years ago

Oh, I lied, sorry. Looking in the wrong place. Not a firefox issue. Is an issue.

Button missing font-icon-edit class.

asecondwill commented 6 years ago

Yep sorry should have said, no 404's. Which makes sense if the class is missing.

robbieaverill commented 6 years ago

PR at https://github.com/silverstripe/silverstripe-lumberjack/pull/79

robbieaverill commented 6 years ago

I'm lying, this was actually fixed in https://github.com/silverstripe/silverstripe-lumberjack/pull/70. I've tagged lumberjack 2.0.0-rc1, so run composer update and you should get that new version with the fix in it. Thanks!

asecondwill commented 6 years ago

confirmed, thanks @robbieaverill