search

silverstripe / silverstripe-blog

Blog module for Silverstripe CMS
http://silverstripe.org/blog-module
BSD 2-Clause "Simplified" License
103 stars 169 forks source link

Everything is private #86

Closed DanielTate closed 11 years ago

DanielTate commented 11 years ago

All the static methods are private. Any reason for this SS is just throwing errors.

Some new installation documentation would be nice if this is the way you indent the module to be.

tractorcow commented 11 years ago

Do you mean the static variables? If you have errors then you're probably using the wrong version of Silverstripe; It's necessary to use the latest 3.1, as there was a rewrite that required configurable variables (such as db, allowed_actions, etc) to be private.

See https://github.com/silverstripe/sapphire/blob/3.1/docs/en/changelogs/3.1.0.md#statics-in-custom-page-classes-need-to-be-private for documentation

halkyon commented 11 years ago

This was done for the recent static changes in SilverStripe 3.1, master always has the latest changes for the latest version of the framework.

If you're looking for a version to use for 3.0, check out 0.6 branch.

DanielTate commented 11 years ago

Thanks. How do I close the issue?

tractorcow commented 11 years ago

There should be a "comment & close" button at the bottom of the screen, or something to that effect.