Campaign Detail Edit Form missing margin

silverstripe / silverstripe-campaign-admin

Campaign and publishing admin interface for Silverstripe

BSD 3-Clause "New" or "Revised" License

2 stars 16 forks source link

Campaign Detail Edit Form missing margin #100

Closed lukereative closed 5 years ago

lukereative commented 6 years ago

The form rendered by renderDetailEditView is missing, this is due to some weird CSS rules with negative margins on 'padded panels' and the fact that this edit form is rendered in react rather than PHP, thus has a different markup than the usual edit form. Ideally we'd unify the two markups so the CSS can be reliably shared between the two.

silverstripe - campaigns 2018-05-07 14-39-37

robbieaverill commented 5 years ago

Fixed by #124

clarkepaul commented 5 years ago

Re-opening this issue as the problem still exists with exactly the same issue—perhaps this was a regression.

The spacing issue on the "Add campaign" screen still exists (using the current demo 4.3 with Chrome).

robbieaverill commented 5 years ago

It's definitely fixed in the 1.3 branch. The demo site is running 4.3.0 (1.3.0 in this module) which isn't fixed, but it'll be in the next patch release (4.3.1).