silverstripe / silverstripe-campaign-admin

Campaign and publishing admin interface for Silverstripe
BSD 3-Clause "New" or "Revised" License
2 stars 16 forks source link

Use PHP 7.2 for Behat, prevents HTTP_RAW_POST_DATA errors #111

Closed robbieaverill closed 6 years ago

robbieaverill commented 6 years ago

The Behat failures (currently on PHP 5.6) are not reproducible locally. I've fixed the artifact upload script path in 7e185c644cc90a905544cd5280358114078a77c3 and checked them - we get this in the screenshot:

https://s3.amazonaws.com/silverstripe-travis-artifacts/silverstripe/silverstripe-campaign-admin/405176020/405176022/screenshots/populate-campaigns.feature_33.png

And this in the logs (hard to tell if this is the cause but it probably is, since it's related to GraphQL):

[Wed Jul 18 02:44:38 2018] PHP Deprecated:  Automatically populating $HTTP_RAW_POST_DATA is deprecated and will be removed in a future version. To avoid this warning set 'always_populate_raw_post_data' to '-1' in php.ini and use the php://input stream instead. in Unknown on line 0
[Wed Jul 18 02:44:38 2018] PHP Warning:  Cannot modify header information - headers already sent in Unknown on line 0

Related: https://github.com/silverstripe/silverstripe-graphql/issues/48

This should hopefully fix the Behat tests in Travis