search

silverstripe / silverstripe-campaign-admin

Campaign and publishing admin interface for Silverstripe
BSD 3-Clause "New" or "Revised" License
2 stars 16 forks source link

FIX Toolbar button margins are constrained to campaign previews, and update ViewModeActions name #112

Closed robbieaverill closed 6 years ago

robbieaverill commented 6 years ago

This CSS style was too broad, so updated to be specific to campaign previews

Also ViewModeActions name changed recently, so updating that too.

Before: image image

After: image

image

maxime-rainville commented 6 years ago

I presume it's not normal for me to loose all campaign actions when I switch to the Edit mode?

https://youtu.be/cAOkDXFGAgE

robbieaverill commented 6 years ago

You're right, but it sounds like a pre-existing bug to me. I'll look at it separate from this PR if that's OK

robbieaverill commented 6 years ago

Hmm @maxime-rainville, you don't have any actions to start with so you aren't really losing any... I can't reproduce your issue.

I've pushed another fix to this branch and have logged https://github.com/silverstripe/silverstripe-campaign-admin/issues/113 for further follow up bugs related to this work