View Mode Toggle bugs

[robbieaverill]

A couple of small bugs that need fixing with view mode toggle:

Don't render toggle until there are items in the campaign (preview is actually used)

When you create a new campaign, there's nothing in it, but view mode toggle is still available. Toggling to preview mode leaves you stuck there with no way to return:

This is only replicateable with a smaller viewport width!

Perhaps this is the preview component with no rendered toolbar. Either way, we can't get back to the edit form.

Probably not rendering the toggle in the "edit form" would be the best solution here.

Remove one pixel left border on preview panel

When preview only mode is enabled, the preview panel has a 1px left border. This shouldn't be there

PR

• [x] https://github.com/silverstripe/silverstripe-campaign-admin/pull/116

[bergice]

Unable to replicate both issues. Tested on 4.2.x-dev.

There is no view mode toggle on the campaign view, but I also tested going into Preview mode on a Page, then navigating to Campaigns.

[robbieaverill]

I think this is 4.3.x, sorry! I totally should’ve mentioned that

[bergice]

In 4.3, when previewing a campaign, the navigation header is hidden, but on smaller resolutions the sidebar is also hidden. It looks like this is the issue here.

Am able to replicate extra border pixel issue now as well.

[maxime-rainville]

@bergice I think this issue got raise following one of my petty complaints. That's what I was seeing at the time, but Robbie was having problem reproducing it. https://youtu.be/cAOkDXFGAgE

[unclecheese]

Per @robbieaverill instructions I was finally able to replicate the issue with the toggle bar.

• create a new empty campaign • resize window down so that preview disappears • notice split mode toggle turns up in the toolbar • change it to preview mode • no way to get back again