silverstripe / silverstripe-campaign-admin

Campaign and publishing admin interface for Silverstripe
BSD 3-Clause "New" or "Revised" License
2 stars 16 forks source link

Border above add to campaign modal actions toolbar #120

Closed robbieaverill closed 5 years ago

robbieaverill commented 5 years ago

image

SS 4.3.x-dev

cc @clarkepaul - I'm not sure, but I suspect it's not meant to be there

clarkepaul commented 5 years ago

The action is supposed to be in the footer of the modal, which spans the whole modal and is fixed to the bottom (default Bootstrap markup). I think the button wasn't easily separated by the form so this was someones attempt to fake the footer. If we can't separate the action into a footer then we should just remove the line (next best thing).

robbieaverill commented 5 years ago

This looks fixed now in SS 4.3.x-dev:

image