Cannot vertically scroll with intro welcome message on vertically small screen

silverstripe / silverstripe-campaign-admin

Campaign and publishing admin interface for Silverstripe

BSD 3-Clause "New" or "Revised" License

2 stars 16 forks source link

Cannot vertically scroll with intro welcome message on vertically small screen #121

Closed robbieaverill closed 5 years ago

robbieaverill commented 5 years ago

SS 4.3.x-dev

If my viewport is the size in the screenshot then I can't scroll down to see what campaigns I have. It made me think I didn't have any. It looks like the splash message has a fixed height while the list of campaigns has panel--scrollable attached to it so it can be scrolled. Perhaps we should make the whole panel scrollable...?

cc @clarkepaul

Pull requests

[x] https://github.com/silverstripe/silverstripe-campaign-admin/pull/132

clarkepaul commented 5 years ago

Yeah, there is no reason the splash banner needs to be fixed, its probably not placed inside the scrollable area. Hopefully it can be moved without too much effort.

robbieaverill commented 5 years ago

👍 also the workaround is to manually close the splash

robbieaverill commented 5 years ago

Easy enough - the padding and scrollable containers can be split and chuck the intro screen in between them. PR at #132

ScopeyNZ commented 5 years ago

Closed by #132