search

silverstripe / silverstripe-campaign-admin

Campaign and publishing admin interface for Silverstripe
BSD 3-Clause "New" or "Revised" License
2 stars 16 forks source link

FIX Use correct versioned state badge designs in campaign admin list items #140

Closed robbieaverill closed 3 years ago

robbieaverill commented 5 years ago

Fixes https://github.com/silverstripe/silverstripe-campaign-admin/issues/77

Requires https://github.com/silverstripe/silverstripe-admin/pull/861 first.

Example screenshot:

image

The "No changes" badge used to be invisible before hovering over it. I haven't carried that change through. Would be nice to run through this with @clarkepaul in person when you're available some time. The colours are in https://github.com/silverstripe/silverstripe-admin/pull/861 and are just $orange and $green variables in admin.

robbieaverill commented 4 years ago

This will need to be updated since the admin PR has changed a bit

emteknetnz commented 3 years ago

This pull request hasn't had any activity for a while. Are you going to be doing further work on it, or would you prefer to close it now?

robbieaverill commented 3 years ago

I can take a look for sure. I seem to remember someone else in the team had made the same change anyway. I'll check tomorrow.