silverstripe / silverstripe-campaign-admin

Campaign and publishing admin interface for Silverstripe
BSD 3-Clause "New" or "Revised" License
2 stars 16 forks source link

Nice to have: ability to unpublish Campaigns #143

Closed rb1t closed 5 years ago

rb1t commented 5 years ago

It would be nice if you could unpublish Campaigns (its contents, from the Campaign admin). For example, we're beginning to use these (with at least one client) and in some cases the campaign content has a finite lifetime.

ScopeyNZ commented 5 years ago

Nice idea. This will probably be powered off some sort of unpublish API on ChangeSet in silverstripe-versioned. If you feel like contributing PRs we'll be happy to review 😄

chillu commented 5 years ago

@silverstripeux How do you feel about this? In my view, the impacts of unpublishing are hard to communicate. It'll be misinterpreted as "revert changes". But it'll also unpublish any changes made after this campaign was originally published. In case you've added new child pages, and the parent page happened to be in the campaign, it'll also make this new child page inaccessible. It just sounds pretty messy overall.

clarkepaul commented 5 years ago

I was trying to avoid this until we get a few other features in there like Scheduled publishing and unpublishing individual items within a campaign. I think it's probably better to think about this issue more as a bulk action of the content within the campaign rather than unpublishing the actual campaign. So in that case, I think there will be times you'll want some of the items in the campaign to be unpublished and other items left as they were. It fits into the same bucket as Expiry where some content might be better being unpublished and other content should probably be archived directly, otherwise, the tree (and content states) will get really messy in the site with what needs to be published and what needs to be archived (typically DRAFT, MODIFIED means this content needs to go live at some stage, and not archived).

I think there are too many edge cases still. Before providing the option to unpublish a campaign we would need to:

Note: unpublishing a page unpublishes all the child pages as well (although this isn't a good experience in its self, it will make unpublishing campaigns super dangerous).

rb1t commented 5 years ago

I hope I haven't opened a can of worms here! As I mentioned in the title, this was very much a 'nice-to-have' idea as it had application with at least one client project. I can appreciate this could be a risky button if added to the CMS, but as clarkepaul mentions, "make it super obvious that what you are about to do is dangerous...". It could - in theory - be solved with a good UI.

Perhaps something to put on the back-burner for another date; bigger fish to fry. Just an idea, as I mentioned.

And to be clear: I'm not an active webdev here at Webbuilders, so I wouldn't be able to do a PR / help contribute to anything other than the discussion at this time :)

chillu commented 5 years ago

Yeah, I'm closing this because I don't think this is going to get actioned anytime soon, given our feedback above. Still a valueable discussion to have, and clarifications for others who might have the same idea.