search

silverstripe / silverstripe-campaign-admin

Campaign and publishing admin interface for Silverstripe
BSD 3-Clause "New" or "Revised" License
2 stars 16 forks source link

Update AddToCampaignHandler.php #149

Closed mxmclaudel closed 4 years ago

mxmclaudel commented 4 years ago

Add to campaign handler should only not show campaigns that are inferred.

mxmclaudel commented 4 years ago

Hi,

I'm slightly confused by the pull request process (I'm fairly new to the contribution process). The default branch is 1, which is behind master. So I don't know which branch this should be merged with... Happy to change if needed. Thanks

mxmclaudel commented 4 years ago

fixes #148

robbieaverill commented 4 years ago

@mxmclaudel thanks for the pull request. FYI, the 1 branch is for the next minor release of SilverStripe 4 (e.g. 4.5.x). The master branch is for SilverStripe 5.x, which is why it's ahead of the 1 branch

mxmclaudel commented 4 years ago

@robbieaverill Thanks for the clarification. I've created a second PR for branch 1 as well.