FIX Add links to userhelp

silverstripe / silverstripe-campaign-admin

Campaign and publishing admin interface for Silverstripe

BSD 3-Clause "New" or "Revised" License

2 stars 16 forks source link

FIX Add links to userhelp #168

Closed emteknetnz closed 3 years ago

emteknetnz commented 4 years ago

Implementation of https://github.com/silverstripe/silverstripe-campaign-admin/issues/127

See comment https://github.com/silverstripe/silverstripe-campaign-admin/issues/127#issuecomment-522394784

Links open in a new tab

Looks like this (reduced screen width)

emteknetnz commented 4 years ago

Scrutinzer error is composer unable to install because this module has "silverstripe/framework": "^4.5", in composer.json, so it attempts to install framework 4.n, meanwhile this campaign-admin branch 1.x-dev wants to installed framework 4.x-dev

Travis does not have this issue since .travis.yml will install silverstripe/recipe-cms:4.x-dev

The scrutinizer failed build doesn't really affect the validity of the code in the pull-request

If anyone is really bothered I can redo this work on 1.6 instead. Let me know if you need this done, or if it's fine as is.

clarkepaul commented 4 years ago

Thanks @emteknetnz ! Long overdue

emteknetnz commented 4 years ago

I've rebased this on top of 1.6. branch name pulls/1/infoscreen-links is misleading, should really be pulls/1.6/infoscreen-links

Scrutinizer issue could be resolved by removing "silverstripe/cms": "^4.5" from require-dev - reason being is that silverstripe/cms requires silverstripe/campaign-admin https://github.com/silverstripe/silverstripe-cms/blob/4.5/composer.json#L23, and we don't have a travis COMPOSER_ROOT_VERSION equivalent for scrutinizer

robbieaverill commented 3 years ago

Can you rebase onto 1? This is not a bug fix so we can't merge it into a patch release branch