search

silverstripe / silverstripe-campaign-admin

Campaign and publishing admin interface for Silverstripe
BSD 3-Clause "New" or "Revised" License
2 stars 16 forks source link

FIX Show Untitled when blank title #171

Closed emteknetnz closed 3 years ago

emteknetnz commented 3 years ago

Fix for https://github.com/dnadesign/silverstripe-elemental/issues/574

Will show "Untitled" for any item that has a blank title, not just content blocks

Before image

After image

ScopeyNZ commented 3 years ago

There's a bit of discussion in the related issue. I personally feel like we should be consistent with elemental here, so the title should be "Untitled Content block" or whatever it is in elemental. Not quite sure how we can put this into code though.

I like the idea of elemental providing a BlockTitle component or something, but I'm not sure how that would tie into campaign admin...

emteknetnz commented 3 years ago

Agree it would be better, though it'll also massively increase the effort required.

There's already context within campaign admin that the thing that is "Untitled" is a "Block"

I'd have a strong preference to keep this PR as is because it still makes things significantly better than they are now.