search

silverstripe / silverstripe-campaign-admin

Campaign and publishing admin interface for Silverstripe
BSD 3-Clause "New" or "Revised" License
2 stars 16 forks source link

BUG Display a notification after publishing a campaign #177

Closed maxime-rainville closed 3 years ago

maxime-rainville commented 3 years ago

Use the new react toast notification to tell the user when their campaign has been published.

Parent issue

Depends on

maxime-rainville commented 3 years ago

Might need to wrtie some unit test and behat test + bump dependencies.

bergice commented 3 years ago

@maxime-rainville, seems to work, just need to update the text and fix travis.

maxime-rainville commented 3 years ago

Updated the messages and added some behat test. The behat test won't be green until the matching framework PR is merged.

maxime-rainville commented 3 years ago

Just had a glance to see if we could sneak in a "successfully added" toast notification is this PR. Sadly, it looks non-trivial.

The add to campaign logic is actually in admin for some weird reason. https://github.com/silverstripe/silverstripe-admin/blob/1/client/src/legacy/AddToCampaignForm.js

maxime-rainville commented 3 years ago

Added a follow up issue for "the add to campaign" modal https://github.com/silverstripe/silverstripe-campaign-admin/issues/190