search

silverstripe / silverstripe-campaign-admin

Campaign and publishing admin interface for Silverstripe
BSD 3-Clause "New" or "Revised" License
2 stars 16 forks source link

Published campaigns can be deleted #54

Open flamerohr opened 7 years ago

flamerohr commented 7 years ago

With all campaigns showing now, it is possible to delete campaigns which has been published. This means that users could be deleting historical data quite easily.

We should restrict deleting to open campaigns which have not been published. And have a filter available to hide already published campaigns.

Luckily the campaigns are sorted by open campaigns first.

chillu commented 6 years ago

@clarkepaul @newleeland Do you agree with this assessment?

clarkepaul commented 6 years ago

Yup sure do :)

newleeland commented 6 years ago

By removing delete, we'll need to provide some sort of explanation of why there's no delete option on some campaigns, while others do!

Having said that, I don' think we should remove the delete button by default. As it will clutter the campaigns section with many campaigns. rather have a warning on delete. Rather than dictate what the user can do.

chillu commented 6 years ago

Campaigns are part of an audit record once they're published, so authors shouldn't be able to delete them. We need to create a UI which reduces the noise of having potentially hundreds of published campaigns in the system. We could split out list views to "open" vs. "recently published", with a "view more" option? Then underneath the "recently published" list, you could have a note about why they can't be deleted.

tractorcow commented 6 years ago

Should be easy... hide published campaigns by default, set canDelete() to false for these records.

clarkepaul commented 6 years ago

Deleting a campaign shouldn't happen but we wanted to see how many campaigns (if any) people usually have open because if they only have 1 then showing the history of published campaigns would make sense but if sites have 15 campaigns on the go then we could look at splitting them apart.