search

silverstripe / silverstripe-campaign-admin

Campaign and publishing admin interface for Silverstripe
BSD 3-Clause "New" or "Revised" License
2 stars 16 forks source link

NEW Use Loading component for campaign admin list view loading states #94

Closed robbieaverill closed 5 years ago

robbieaverill commented 6 years ago

Replaces a text based loading indicator, and implements the admin's Loading indicator component over duplicating the divs in various places.

Requires https://github.com/silverstripe/silverstripe-admin/pull/490

robbieaverill commented 6 years ago

Ping me when reviewing and I'll rebase

maxime-rainville commented 5 years ago

I gave a go at reviewing/rebasing this, but it looks like there's but other change introduced since then that introduced extra conflicts.

If you want to resolve the conflicts, I'll review it.

robbieaverill commented 5 years ago

I think this has been done in another PR now, closing