search

silverstripe / silverstripe-campaign-admin

Campaign and publishing admin interface for Silverstripe
BSD 3-Clause "New" or "Revised" License
2 stars 16 forks source link

MINOR Use more object destructuring and spread syntax #96

Closed robbieaverill closed 5 years ago

robbieaverill commented 6 years ago

Uses destructuring more in props, and replaces Object.assign with spread syntax

Also fixes #96

robbieaverill commented 6 years ago

Ping me when reviewing and I'll rebase

maxime-rainville commented 5 years ago

@robbieaverill I'll peer review it if you want, but looks like there's quite a bit of merge conflicts in there.

robbieaverill commented 5 years ago

@maxime-rainville updated, I've also added the missing translation defaults to en.json, added one which was not translated yet and switched the two sprintf style translations which weren't in the source dictionary yet to use inject instead while I was there