More padding for column checkboxes (in gridfieldextensions)

silverstripe / silverstripe-ckan-registry

BSD 3-Clause "New" or "Revised" License

6 stars 3 forks source link

More padding for column checkboxes (in gridfieldextensions) #101

Open brynwhyman opened 5 years ago

brynwhyman commented 5 years ago

Update styling so the whole cell/padding for column's 'in results'/'in detail' checkbox is selectable.

Action this in: https://github.com/symbiote/silverstripe-gridfieldextensions/issues/281

robbieaverill commented 5 years ago

I think this needs to be raised on symbiote/silverstripe-gridfieldextensions, since that's the component that renders the inline editable checkboxes and the same request here would be valid for all implementations of it.

Things to consider when doing this:

We may need to add a label for the checkbox in order to make it clickable
The label needs to be accessible and not confuse screenreaders
The checkbox identifies the column header as its label at the moment, we'd need to change that to the label

robbieaverill commented 5 years ago

Thoughts @brynwhyman?

ScopeyNZ commented 5 years ago

I agree it belongs on GridFieldExtensions. I think there should be a variant (probably through configuration) that allows label-less checkboxes in columns. It can still be screen reader friendly with appropriate html attributes. I personally would prefer that it also involve making the whole table cell the label for the checkbox - ie. making a click anywhere on the cell toggle the checkbox.

brynwhyman commented 5 years ago

Moved to: https://github.com/symbiote/silverstripe-gridfieldextensions/issues/281

I'll keep this ticket in CKAN to track whether we action this as part of the CKAN initiative currently underway.