search

silverstripe / silverstripe-ckan-registry

BSD 3-Clause "New" or "Revised" License
6 stars 3 forks source link

MNT Fix unit test #305

Closed emteknetnz closed 11 months ago

emteknetnz commented 11 months ago

Issue https://github.com/silverstripe/.github/issues/162

Replaces https://github.com/silverstripe/silverstripe-framework/pull/11075

Fixes https://github.com/silverstripe/silverstripe-ckan-registry/actions/runs/7019350079/job/19122212114#step:12:71

1) SilverStripe\CKANRegistry\Tests\Forms\GridField\GridFieldDetailForm\ResourceFieldItemRequestTest::testSortingOnResourceSave
Error: Call to a member function addHeader() on null

Debugging this locally, the controller being returned was a Mock_Controller

Broke as a result of https://github.com/silverstripe/silverstripe-framework/commit/d883719c16075412640e623557a2df4275965de1#diff-a78442d492fa67baadddeeb396bbdbf9f9ff98f000848292eee8ab99c73aaf09R723

sabina-talipova commented 11 months ago

Close, since this issue was solved in this PR https://github.com/silverstripe/silverstripe-ckan-registry/pull/304