Delete parent page, child pages cannot be found anymore

[stojg]

How to recreate this bug:

First ensure that you have enough pages in the site tree so it doesn't pre-load all of your level two pages.

• Create page A in root and "Save and publish” (ensure it's at the bottom so it's not automatically pre-loaded)
• Create child page B under A and “Save and publish"
• "Unpublish" and "delete draft" for A

Observe that in the minimised site-tree shows A has a “Deleted” label, but no label on B

• Click the “Pages” admin link

BUG: Observe that A and B is still showing (bug?)

• Refresh page, and notice that A and B is gone from the site-tree
  • Choose the “All pages, including deleted” filter and click “Apply Filter”

Observe that A is showing, but not B

• “Restore” and “Save & Publish" A
• Click the “Pages” admin link

BUG: Observe that “A” doesn’t show up anymore

• Reload the page

BUG: A shows up, but not “B” B cannot be found and restored any more?

[tractorcow]

https://github.com/silverstripe/silverstripe-cms/commit/3204ab5af35796ef5aa28331b821bea1549a4c2d#commitcomment-7007242

Perhaps this is an issue with the isOrphaned check? CMS users should still be able to view orphaned pages though, so maybe it's just a permission tweak.

[stojg]

No, the parent page is still there, but everything is for sure everything is connected in versioned / hierarchy in someway.. so who knows.

It might be related to Hierarchy::numChildren() that returns 0 number of childrens for a page with deleted children... might..

[stojg]

Yeah, I found the problem, will make a PR for this. As a side note, we need more automatic test that actually uses the hierarchy.

[stojg]

This seems to be an issue when the framework is using the default numChildren() when the code should use numHistoricalChildren()

[stojg]

Work in progress:

• https://github.com/stojg/sapphire/compare/issue/cms-1049
• https://github.com/stojg/silverstripe-cms/compare/issue/cms-1049

[stojg]

To help reproduce this issue I have created a SS 3.1 MySQL database dump that can be downloaded from https://stojg.se/assets/SS_sandboxdev.sql.gz (warning, it uses delete tables before import).

The live published site tree look like this:

Observe section 08 in the above image

If I in the 3.1 branch filters for all "Deleted pages" it looks like this:

As it can be seen, it's not possible to open Section 08 because it calculates the wrong number of children.

In the patches provided the same view looks like this:

Section 08 can now be opened and the deleted child page can be restored.

[stojg]

I have tested Groups, Folders and fields like TreeDropDown field.

[stojg]

Even if not all things marked as BUG in the description, the most important one was fixed (BUG: A shows up, but not “B”).

[stojg]

thanks @tractorcow for doing the peer review and merging.