search

silverstripe / silverstripe-cms

Silverstripe CMS - this is a module for Silverstripe Framework rather than a standalone app. Use https://github.com/silverstripe/silverstripe-installer/ to set this up.
http://silverstripe.org/
BSD 3-Clause "New" or "Revised" License
512 stars 332 forks source link

New Page Still in Draft/Modified after Published #2309

Closed pxwee5 closed 5 years ago

pxwee5 commented 6 years ago

Affected Version

Composer settings: "silverstripe/framework": "4.2.x-dev", Composer info: silverstripe/framework 4.x-dev c23d21a

Description

image

Edited pages still display as draft/modified after I published the page.

Steps to Reproduce

  1. Create a page
  2. Change title
  3. Press publish

This issue wasn't around in 4.1 I think, I wanted to use the setContentCSS method in TinyMCEConfig so I had to upgrade SS framework. After I upgrade, this bug was introduced.

maxime-rainville commented 6 years ago

I can replicate the behavior in 4.1 and 4.x-dev.

What I think is going on is that when you click Publish straight after updating the title of a brand new page, a call is made to retrieve a suggested URL Segment, which blocks the publish request.

If you don't change the page title and click publish, it works. If you focus on another form field before clicking publish, the suggested URL segment is fetch and Publish works.

pxwee5 commented 6 years ago

4.1@stable does not have this issue btw.

cwchong commented 5 years ago

Am experiencing this, not quite sure what's causing this, because I can see the pages in the database under SiteTree_Live so they should be picked up as published.

The "More Options" button at the foot also will not reflect the publish status of the page.

I think this is quite a breaking UI bug in the CMS.

ScopeyNZ commented 5 years ago

Can you provide some more detail about the relationships on the pages that are not publishing correctly? Are you using a module like silverstripe-elemental?

amolswnz commented 5 years ago

I have similar issue Tested on versions 4.2.1 and 4.3.3 (no additional modules installed)

Steps to reproduce

  1. Create new Page type and Save (do not Publish).
  2. Create new child page and leave in draft mode.
  3. Add another child page and leave in draft mode.
  4. Publish the top level page.
  5. Publish the child level pages.

Site tree will show all the pages as DRAFT If you skip step 3 then only child page will show as DRAFT

amolswnz commented 5 years ago

Another issue is the bulk publishing (If the parent page is in draft mode)

SilverStripe 4.2.1 - Bulk publishing error is thrown. None of the pages are published. Request URL: http://example.com/admin/pages/ Request Method: GET Status Code: 400 Bad Request Response Ajax requests to this URL require an X-Pjax header.

SilverStripe 4.3.3 - Bulk publishing no error thrown Parent and child pages are published. But child pages are shown as Draft in CMS.

amolswnz commented 5 years ago

I have tested this on SilverStripe 4.4.0 and the issues does not seems to replicate.

chillu commented 5 years ago

Thanks Amol!