search

silverstripe / silverstripe-cms

Silverstripe CMS - this is a module for Silverstripe Framework rather than a standalone app. Use https://github.com/silverstripe/silverstripe-installer/ to set this up.
http://silverstripe.org/
BSD 3-Clause "New" or "Revised" License
516 stars 333 forks source link

jstree highlights wrong element when doing a drag and drop reordering in some circumstances #2315

Closed ss23 closed 4 years ago

ss23 commented 9 years ago

(this is logged here because jstree is in framework, not cms)

Assume you have 3 pages in the root. Select Page with ID 1. Click and drag Page with ID 2 to a new position in the site tree.

Expected: The content is still of Page 1. The URL is still of Page 1. Page 1 shows as selected in the jstree. Actual: The content is still of Page 1. The URL is still of Page 1. Page 2 shows as selected in the jstree.

We're currently running the lasted version of jstree of the .1 branch (though it has been monkeypatched), and my JS skills aren't enough to fix it myself. ux

maxime-rainville commented 5 years ago

Just had a look in SS4. Looks like this is still present ... sort of. That's the interaction I have https://youtu.be/iBQEWx2S55g

Looks like we provide a slight highlight of the currently selected page. I wouldn't call this highlight a "selection marker". I would consider it more like "here's the last thing you interacted with".

I don't think this is a bug per se. Probably more of a UX question. @clarkepaul

bergice commented 4 years ago

Tested on SS 4.6, looks to no longer be an issue. SS 3 is now in limited support so I'll close for now.

Reopen if this is still an issue in SS 4.