search

silverstripe / silverstripe-cms

Silverstripe CMS - this is a module for Silverstripe Framework rather than a standalone app. Use https://github.com/silverstripe/silverstripe-installer/ to set this up.
http://silverstripe.org/
BSD 3-Clause "New" or "Revised" License
516 stars 333 forks source link

Add page UI options shouldn't be set back , padding missing on smaller viewports #2372

Open clarkepaul opened 5 years ago

clarkepaul commented 5 years ago

The page types within the add page UI shouldn't have a negative margin on the left, on smaller viewports these page options touch the CMS menu.

pasted_image_28_01_19__12_59_pm

CSS to remove: image

maxime-rainville commented 5 years ago

Just had a quick look. If the left/right margin can remove, the step 2 option get misaligned relative to the step 1.

image

clarkepaul commented 5 years ago

Yeah I saw that, I thought it was the lesser of two evils. Ideally we would remove the padding around page selection of pages and revert back to the default checkbox style.

A side note is that we would eventually redesign this experience to make adding pages possible directly from the site tree rather than having to navigate away (similar to the add block functionality of Elemental), although that will be a way off development wise.

ScopeyNZ commented 5 years ago

Would that use the same design pattern as elemental? Using PopoverOptionSet?

clarkepaul commented 5 years ago

Probably @ScopeyNZ , your favourite component :)