Tabs get overlayed - Githubissues

silverstripe / silverstripe-cms

Silverstripe CMS - this is a module for Silverstripe Framework rather than a standalone app. Use https://github.com/silverstripe/silverstripe-installer/ to set this up.

http://silverstripe.org/

BSD 3-Clause "New" or "Revised" License

516 stars 333 forks source link

Tabs get overlayed #2405

Closed emteknetnz closed 4 years ago

emteknetnz commented 5 years ago

SilverStripe 4.3.1

I've seen this sort of thing several times

In this particular instance, it's editable a user form (content block)

It seems like the <div class="cms-content-header-tabs"> that contains the tabs are in the wrong place

Perhaps:

toolbar --> cms-content-header-tabs
panel

Should be:

toolbar
panel --> cms-content-header-tabs

chillu commented 5 years ago

@emteknetnz What version of userforms is that? I can't reproduce this on 4.3.x-dev (through https://github.com/silverstripe/cwp-recipe-kitchen-sink)

emteknetnz commented 5 years ago

Don't know which version of userforms sorry, I should have recorded that info at the time. I've now lost context of which website I saw this behaviour on

chillu commented 5 years ago

OK, I'm closing until somebody can tell me a composer info to reproduce this on

brynwhyman commented 5 years ago

I saw this recently too, so have reconfirmed. It's two-fold:

silverstripe/userforms 5.4.x-dev and silverstripe/cms 4.4.x-dev breaks at mobile resolutions only (<465px wide)
dnadesign/silverstripe-elemental-userforms 3.0.x-dev breaks at a much wider view (<933px wide) - likely what @emteknetnz encountered. Although when building a userform with this module, split mode isn't available, so it seems unlikely that a user would see this view.

Will leave for @chillu to reopen, if required.

JakubDolba commented 5 years ago

Reproducible with silverstripe/framework 4.3.x and any silverstripe/admin (probably all framework 4.x)

just use any browser dev console and manually add few more tab-menu li items into ul in cms-tabset-nav-primary and adjust browser window width
- not related to user-forms

brynwhyman commented 5 years ago

We've had further reports of this bug,

they have quite a lot of menu-items and it is broken (easily reproducible in any browser)

samandeggs commented 4 years ago

Having this issue as well, client has about 8 tabs in one particular menu area. Not really wanting to write custom css for the admin area. composer.json is based around "silverstripe/recipe-cms": "^4.4.4"

kinglozzer commented 4 years ago

Fixed in https://github.com/silverstripe/silverstripe-admin/pull/906