silverstripe / silverstripe-cms

Silverstripe CMS - this is a module for Silverstripe Framework rather than a standalone app. Use https://github.com/silverstripe/silverstripe-installer/ to set this up.
http://silverstripe.org/
BSD 3-Clause "New" or "Revised" License
512 stars 331 forks source link

Remove old installer logic from ContentController #2958

Closed maxime-rainville closed 3 months ago

maxime-rainville commented 3 months ago

We used to have an installer that could be use to set up your environment file via a browser form.

We got rid of that some time ago, but there's bits of logic left in Content Controller to handle that. At first glance, these bits look mildly scary because they are printing out credentials, pinging back some silverstripe domain and deleting files. Glancing at the fine print of the code, I don't think there's any risk. But it's certainly not code we should be keeping around.

I don't think there's anything useful that can be done with this code anyway, so we can probably removed it in CMS 5.

https://github.com/silverstripe/silverstripe-cms/blob/56646af3602c78f7963e459095c9dabe48476470/code/Controllers/ContentController.php#L442-L515

Acceptance criteria

CMS 5 PRs

CMS 6 PRs

NOTE Don't merge these until the CMS 5 PRs have been merged in and up - this is to ensure we don't get deprecation notices popping up in weird places due to bad mergeups.

emteknetnz commented 3 months ago

Reassigning to Guy to merge-up and update CMS 6 PRs